mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

** Changed in: mahara
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1792246

Title:
  make a more generic js workround for target _blank

Status in Mahara:
  Fix Committed

Bug description:
  In bug https://bugs.launchpad.net/mahara/+bug/1558361 we removed the
  use of target _blank because of XSS issues.

  There is a js workaround to the problem now and so we can allow the
  'target="_blank" again and then override it via jQuery.

  Actually it would be safer to do something like 'data-target="_blank"'
  that way if a jQuery error is created on the page the link would not
  fall back to old behaviour

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1792246/+subscriptions