mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Now we have merged the patch it means the group arrow-bar menu items are
handled slightly differently.

Before: 
If on a group page that had for example:

define('MENUITEM', 'groups/members');

This would highlight the 'members' tab in the arrow bar by matching on
the 'path' value of the groups menu by looking for path beginning with
'groups/'

But that wouldn't highlight the correct main nav submenu item

So, now we have 2 definitions:

define('MENUITEM', 'engage/mygroups');
define('MENUITEM_SUBPAGE', 'members');

so the group tab is highlighted based on 'MENUITEM_SUBPAGE' value and
this matches to the key of the group menu to highlight arrow-bar tab

and now we can specify the correct main nav submenu to highlighted as
well

This makes it more in line with how resume arrow-bar works

In case you have sites that call custom 'group_tabs()' functions just
make sure the page it calls has

define('MENUITEM_SUBPAGE', 'keyname');

where 'keyname' matches the related key of the group menu item array

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1792263

Title:
  Tidy up pages matching new menu items

Status in Mahara:
  Fix Committed

Bug description:
  This patch will fix up things that were missed by
  https://bugs.launchpad.net/mahara/+bug/1782954

  To get it better ready for
  https://bugs.launchpad.net/mahara/+bug/1792252

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1792263/+subscriptions