← Back to team overview

mahara-contributors team mailing list archive

[Bug 1794370] A change has been merged

 

Reviewed:  https://reviews.mahara.org/9151
Committed: https://git.mahara.org/mahara/mahara/commit/10267404f2bb2652c5ec9de496f0221dc12d13e5
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit 10267404f2bb2652c5ec9de496f0221dc12d13e5
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Sep 26 08:59:21 2018 +1200

Bug 1794370: Use correct owner for watchlist message

When sending watchlist notification for block changes in a view

behatnotneeded

Change-Id: Ieeb89c6662acabd8438486702e10433ea6feab70
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 0866ac938ff6d973c14b8238ab8109f6a87440f0)
(cherry picked from commit d67773e5705f08abbb84e18849460d97ea8d4488)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1794370

Title:
  Block change watchlist notification not displaying correct owner

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Scenario:

  A watched page has it's blocks changed (added/modified/deleted) and
  this causes a watchlist notification to be generated.

  Problem:

  The message in the watchlist notification 'The page "%s" belonging to
  %s has been changed' can becoume incorrect under the following
  circumstance - if the person triggering the 'watchlist_record_changes'
  event is not the page owner then their name is displayed as the
  'belonging to %s' part.

  This is incorrect and it should show the page owner instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1794370/+subscriptions


References