mahara-contributors team mailing list archive

[Mahara Bot <1796452@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9209
Committed: https://git.mahara.org/mahara/mahara/commit/12a776e9b459f2cd45d677e061a6949b82b196f8
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    18.10_STABLE

commit 12a776e9b459f2cd45d677e061a6949b82b196f8
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Oct 8 09:12:37 2018 +1300

Bug 1796452: Allow role options for group/user to display on edit

Even if the role selected was no specific role

behatnotneeded

Change-Id: I21718fe4880ad65e0b0205d6a2a5179fa3c1d001
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit c335ab77ada9907249b9ebc2274f032e6bdbcc77)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1796452

Title:
  Peer / manager role can only be given on first save of "Edit access"

Status in Mahara:
  Fix Committed

Bug description:
  When a user shall receive the "Manager" role, it is not possible to
  give it to them if the form had already been saved once. It can only
  be given upon the first time of selecting the user. It needs to be
  possible at all times though.

  To replicate:

  1. Make sure that the sign-off block is installed on your site.
  2. Create a page that contains the sign-off block.
  3. Share the page with another user by going to "Search for..." on "Edit access" in the "Share with" drop-down menu and select a user. Do not give the "Manager" role.
  4. Save the page.
  5. Click on "Share" again (or go via "Shared by me" to edit the access).
  6. You see the user selected under "Shared with".
  Expected result: The third drop-down with the text "No special role" displayed should be visible and available for selection.
  Actual result: It is not available.

  You have to remove the user, save the form, and then open the page
  again to add the user in order to give them their role.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1796452/+subscriptions