← Back to team overview

mahara-contributors team mailing list archive

[Bug 1797976] A change has been merged

 

Reviewed:  https://reviews.mahara.org/9223
Committed: https://git.mahara.org/mahara/mahara/commit/38e0d66fcc344f19562af6f0e8515b3f1987c5c5
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    18.10_STABLE

commit 38e0d66fcc344f19562af6f0e8515b3f1987c5c5
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Tue Oct 16 16:56:26 2018 +1300

Bug 1797976: stop processing form when cancel in matrix assessment

behatnotneeded

Change-Id: Icb27d150bf05953c60c11739cffa81f63ba9f42c
(cherry picked from commit 0028cd2e2992a9ac64742214b696599e537136d5)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1797976

Title:
   Clicking cancel for the (do you want to leave page) pop up modal
  starts processing and computer hangs

Status in Mahara:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Bug Summary: Assessor is making an assessment on Smart evidence Collection - User places feedbak but does not click the place feedback button - User then makes the assessment (doesn't meet) and clicks save -> pop up is displayed (do you want to leave page) - user clicks cancel = Save button now displays "Processing" and computer hangs 
  -----------------------

  Environment tested: Master
  Browser tested: Chrome, MS Edge (VM) 

  Preconditions:
  1. User has submitted Collection for smart evidence 
  2. Assessor is assessing Collection 

  Test Steps: 
  1. User places feedbak but does not click the place feedback button 
  2. User then makes the assessment (doesn't meet) and clicks save 
  3. Pop up is displayed (do you want to leave page) 
  4. User clicks cancel 
  -----------------------

  Actual result: Save button now displays "Processing" and computer
  hangs - user must now click Cancel to the right of the Processing
  button

  Expected result: Popp up closes and assessment modal remains open with
  the assessment selected and the feedback still displayed and  "Save"
  button does not start to process

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1797976/+subscriptions


References