← Back to team overview

mahara-contributors team mailing list archive

[Bug 1802205] A change has been merged

 

Reviewed:  https://reviews.mahara.org/9295
Committed: https://git.mahara.org/mahara/mahara/commit/ce4e3d8a1f369995f135f8decb41e6fad8e56a42
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit ce4e3d8a1f369995f135f8decb41e6fad8e56a42
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Nov 8 13:07:58 2018 +1300

Bug 1802205: All external links to be opened in new tab/window by
default

Except for those that have 'target="_self"'

And also have any internal links with 'target="_blank"' to open
externally

Open them in safe noopener way

behatnotneeded

Change-Id: I445034bb2fd2e039c9380dc7a1b29382542e7100
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1802205

Title:
  Make all external links in Mahara open in external tab/window by
  default

Status in Mahara:
  Fix Committed

Bug description:
  Whether an external <a> link has target=_blank or not we should open
  them in external tab/window to differentiate mahara site from external
  content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1802205/+subscriptions


References