mahara-contributors team mailing list archive

[Mahara Bot <1796600@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9205
Committed: https://git.mahara.org/mahara/mahara/commit/080e4c2b3df0784f00cbfa26644ff20b069e2a16
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 080e4c2b3df0784f00cbfa26644ff20b069e2a16
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Oct 8 13:25:24 2018 +1300

Bug 1796600: Getting progress meter to display again

Getting it to flow more smoothly as well

Note: does not fix copy page to existing group members as that form
breaks horible when submitting as js

behatnotneeded

Change-Id: Icbf437990ae06fc717199b6735007d9dcb2c885a
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1796600

Title:
  Forms that use progress bar when saving now do not show progress bar

Status in Mahara:
  Fix Committed

Bug description:
  When saving on view access screen there is a "sendjsonrequest()
  failed: error" in the browser console

  This is because of the following problems:

  1) The saving of the access does a check to see if we should display the progress meter bar
   - it does this on any save - yet the progress meter is only meant for the saving when 'copy page to existing users' when saving a group page

  2) The form saves in a non-js form way yet the ajax call to the
  progress meter needs to be done is a jsfrom way - otherwise the
  brwoser goes to new page an ajax fails before result is returned

  What is needed is get the access form to save as a jsform and then to
  only use the progress meter if doing copy page event

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1796600/+subscriptions