mahara-contributors team mailing list archive

[Mahara Bot <1813862@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9505
Committed: https://git.mahara.org/mahara/mahara/commit/6525e6b329f0dd867d373bcf3ba5723e147fad68
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.10_STABLE

commit 6525e6b329f0dd867d373bcf3ba5723e147fad68
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Nov 7 07:47:31 2018 +1300

Bug 1813862: Remove old Mochikit function call

And replace it with equivalent jQuery call

behatnotneeded

Change-Id: I26855778c53ac36591b6188c477f25648dab9057
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e)
(cherry picked from commit e3fa699be8ca0970e0f776551afb2dc8e981c4ef)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1813862

Title:
   Old Mochikit function still in views.js for 17.10

Status in Mahara:
  New
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Need to backport bug fix for https://bugs.launchpad.net/bugs/1801993
  into 17.10

  This old Mochikit function is breaking the "Add block" call when editing a page.
  To test:
  - Create a page and click on "Edit"
  - Click on "Text" in the block menu
  - Click on the "Add" button

  Expected result: the block is added on the page
  Actual result: the pop-up window is hidden but the block is not added to the page. There is also an error message in the js console of the browser

  "ReferenceError: getViewportDimensions is not defined"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1813862/+subscriptions