mahara-contributors team mailing list archive

[Mahara Bot <1773600@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9582
Committed: https://git.mahara.org/mahara/mahara/commit/6ce6a4f5ccc47a6060f9524ca0aef57c21eb8936
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 6ce6a4f5ccc47a6060f9524ca0aef57c21eb8936
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Tue Feb 19 17:31:15 2019 +1300

Bug 1773600: Correct captilization of time registration expiry selector

Created new lowercase string arrays for singular and plural time units.
Altered the expirystring to reflect changes.

behatnotneeded

Change-Id: I1555325f24843a628305cd6afe9cc9b45f8d5d94
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1773600

Title:
  Correct capitalization of time registration expiry selector

Status in Mahara:
  Fix Committed

Bug description:
  In Admin -> Configure site -> Site options -> Account settings you can
  choose the "Default registration expiry lifetime". This drop-down menu
  displays the correct options with the correct capitalization.

  However, when an admin receives the registration request email, the
  time period is capitalized as it is taken from the drop-down menu,
  e.g.

  "You will need to approve or deny this registration request within 2
  Weeks."

  However, it should read:

  "You will need to approve or deny this registration request within 2
  weeks."

  A new set of strings should be set up that shows "days", "weeks",
  "months", "years" not capitalized so that these strings can be used in
  the HTML and plain text emails sent out for this message.
  Unfortunately, it's not just a case of renaming the strings as their
  capitalized versions need to be kept in the pieforms element for the
  drop-down menu.

  To replicate:

  1. Activate the "Default registration expiry lifetime" and set it to a number of days / weeks / months / years.
  2. turn on "Confirm registration" in an institution on the site and allow self-registration.
  3. Self-register for an account in the institution.
  4. Check the email you'd receive either as admin of the institution or site admin.

  Expected result: "You will need to approve or deny this registration request within 2 weeks." (or days / months / years)
  Actual result: "You will need to approve or deny this registration request within 2 Weeks." (or Days / Months / Years)

  All options, including the "No end date set" one should be tested as
  well as the plain text and HTML messages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1773600/+subscriptions