mahara-contributors team mailing list archive

[Mahara Bot <1765276@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9040
Committed: https://git.mahara.org/mahara/mahara/commit/c3ea0a8f388f66bbf33158eed7ea300a7dae4513
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit c3ea0a8f388f66bbf33158eed7ea300a7dae4513
Author: Liam <liam.sharpe@xxxxxxxxxxxxxxx>
Date:   Fri Aug 3 11:32:45 2018 +1200

Bug #1765276: Fixing errors from Jaques email (pasted below)

1. Change all 0px references to 0
2. Fix &focus --> &:focus in raw/sass/_buttons.scss
3. why is $navbar-height replaced with 30px in raw/sass/_main-nav.scss
4. Any reason styles commented out are left in see example
raw/sass/_main-nav.scss
5. Why @includes commented out in /sass/components/_arrow-bar.scss
6. Comment?? line 42 of /sass/components/_pagination.scss
7. New file not in master?? sass/features/_features.scss
8. Remove file --> sass/views.scss
9. Remove commented styles --> sass/layout/card/_card-collapse.scss
10. How did you determine hidden-xs should be replaced with d-none
d-sm-block -->https://reviews.mahara.org/#/c/8947/1/htdocs/lib/web.php
10B. What is the reasoning for adding the background: white to -->
https://reviews.mahara.org/#/c/8947/1/htdocs/theme/raw/sass/components/_list-group.scss
11. Confirm if 14px the default $font-size-base we going with -->
https://reviews.mahara.org/#/c/8947/1/htdocs/theme/raw/sass/utilities/_bootstrap-variables.scss
12. how did you determine use of d-md-block for -->
https://reviews.mahara.org/#/c/8947/1/htdocs/theme/raw/templates/styleguide.tpl
13. Why is additional "Roboto Slab" font added -->
https://reviews.mahara.org/#/c/8947/1/htdocs/theme/raw/sass/utilities/_bootstrap-variables.scss
14. Reason for removing @include media breakpoint -->
https://reviews.mahara.org/#/c/8948/1/htdocs/theme/raw/sass/form/_dropdown-group.scss
15. Why is border-radius changed -->
https://reviews.mahara.org/#/c/8948/1/htdocs/theme/raw/sass/utilities/_bootstrap-variables.scss
16. Remove extra indentation -->
https://reviews.mahara.org/#/c/8957/1/htdocs/theme/raw/sass/components/_btn.scss
17. Reason for uncomment of tinymce -->
https://reviews.mahara.org/#/c/8957/1/htdocs/theme/raw/sass/utilities/_index.scss
18. Reason for dropping caret -->
https://reviews.mahara.org/#/c/8987/2/htdocs/theme/raw/sass/lib/bootstrap4/_dropdown.scss
19. Reason why .link-thumb lighten changed to darken
-->https://reviews.mahara.org/#/c/9001/1/htdocs/theme/raw/sass/components/_link-thumb.scss
20. Duplicate &bg-danger {} -->
https://reviews.mahara.org/#/c/9001/1/htdocs/theme/raw/sass/layout/card/_card-colors.scss


behatnotneeded

Change-Id: I0835eca79ef42e8f768a3d1213a3580796d64dcb

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1765276

Title:
  Upgrade to Bootstrap 4

Status in Mahara:
  In Progress

Bug description:
  Bootstrap 4 has been released. We should upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1765276/+subscriptions