mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #52068
[Bug 1792474] Re: Have pieforms to always throw an exception if called after smarty() call
** Changed in: mahara
Importance: Medium => Wishlist
** Changed in: mahara
Milestone: 19.04.0 => None
** Tags added: refactoring
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1792474
Title:
Have pieforms to always throw an exception if called after smarty()
call
Status in Mahara:
Confirmed
Bug description:
Sometimes when trying to add a form to a page we get an error similar
to this:
Pieform element xxxxxxx wants to add headdata to the page, but it's
too late. Build your form before generating the page.
It is meaning we need to generate the form before getting to the call
$smarty = smarty();
It is due to some pieform fields needing to add content to the <head>
of a page via the pieform_element_*_get_headdata() function , such as
a calendar field, that rely on certain js/css to function correctly.
However, some other pieform fields do not have this problem, and so
can cause confusion for developers
It would be better to force all pieform content to be generated before
the smarty() call for consistency
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1792474/+subscriptions
References
