mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #52100
[Bug 1742590] Re: Text/Note/Annotation Maxlength rule is unnecessary
Environment tested: Master
Browser tested: Chrome
PRECONDITIONS:
------------------------
1) Mahara user exists (no roles)
2) Image has been converted to a Base64 hash text
3) Portfolio page exists that was created by another user and is shared with public
TEST STEPS: Allow large Base64 hash text
------------------------
1) Log in as Mahara user
2) Browse to a portfolio page that has been made public by another user
3) Make a comment on the page as follows
a) In the WYSIWYG editor click the source icon (should open a text field modal with title Source code)
b) Enter the Image that has been converted to a Base64 hash text and click OK
c) Publish the comment by clicking the comment button
4) Verify that an image is displayed in the comment field ✔
5) Verify that there are no error messages ✔
5) Edit the comment - **Note:** that the long has has been converted to a blob of text and add another Image that has been converted to a Base64 hash text and click OK
6) Verify that the second image has been added to the comment ✔
7) Remove the comment
8) Verify that the comment has been removed and no error message is displayed ✔
TEST STEPS: Max 1000,000 chars allowed in text fields
------------------------
1) Log in as Mahara user
2) Browse to a portfolio page that has been made public by another user
3) Make a comment on the page using more than 1,000,000 characters into the text field and publish
4) Verify that an error message is displayed as follows
* "This field must be at most 1,000,000 characters long. Please revise it or try splitting this over multiple instances." ✔
5) Make a comment on the page using less than 1,000,000 characters into the text field
6) Verify that text is published ✔
Catalyst QA Approved ✔
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742590
Title:
Text/Note/Annotation Maxlength rule is unnecessary
Status in Mahara:
In Progress
Bug description:
Mahara: 17.10.1
OS: Ubuntu 16.04
DB: Postgres
Browser: FF
When inserting a base-64 encoded image into a comment on a form, the
user is presented with the following error:
'This field must be 8192 characters long.'
This rule validation is not really required because the DB field that
it inserting into is a 'Text' type. Which basically means it's almost
unlimited.
Postgres 7.1+ does have an upper limit at 1 Gb for a Text field.
Mahara supports Postgres 9+.
I do think it's safe to remove the maxlength rule for the Text, Note
and Annoation fields.
Please let me know your thoughts.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742590/+subscriptions
References