← Back to team overview

mahara-contributors team mailing list archive

[Bug 1820774] A change has been merged

 

Reviewed:  https://reviews.mahara.org/9643
Committed: https://git.mahara.org/mahara/mahara/commit/511d5e8f684b1797771fb0aa6809b896556d2f31
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.10_STABLE

commit 511d5e8f684b1797771fb0aa6809b896556d2f31
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Mar 19 13:31:03 2019 +1300

Bug 1820774: Need to have full url in Resume -> introduction link

In the arrow menu
So that it woeks on sites with clean urls

behatnotneeded

Change-Id: I1a20ae15dfac41db236b8862a7738f1e991d5480
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 099fb56d969b3d6b4ec7816df26332162bc6a619)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820774

Title:
  Resume 'introduction' submenu not working in clean urls site

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  Go to artefact/resume/index.php

  And click on the 'Introduction' arrow menu item

  When on non clean urls site it loads the page correctly

  But on a clean urls site we get an error:

  Page not found
  You tried to access a page that does not exist.

  Page resume by artefact not found.

  
  This is when we have the following rewrite rules in place:
        RewriteRule ^/user/([a-z0-9-]+)/?$ /user/view.php?profile=$1&%{QUERY_STRING}
        RewriteRule ^/user/([a-z0-9-]+)/([a-z0-9-]+)/?$ /view/view.php?profile=$1&page=$2&%{QUERY_STRING}
        RewriteRule ^/group/([a-z0-9-]+)/?$ /group/view.php?homepage=$1&%{QUERY_STRING}
        RewriteRule ^/group/([a-z0-9-]+)/([a-z0-9-]+)/?$ /view/view.php?homepage=$1&page=$2&%{QUERY_STRING}
        RewriteRule ^/([a-z0-9-]+)/?$ /user/view.php?profile=$1&%{QUERY_STRING}
        RewriteRule ^/([a-z0-9-]+)/([a-z0-9-]+)/?$ /view/view.php?profile=$1&page=$2&%{QUERY_STRING}

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820774/+subscriptions


References