mahara-contributors team mailing list archive

[Mahara Bot <1812910@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9584
Committed: https://git.mahara.org/mahara/mahara/commit/98ee2ce6579868400566be8e71c81f943d7317f2
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    18.04_STABLE

commit 98ee2ce6579868400566be8e71c81f943d7317f2
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Feb 4 13:30:58 2019 +1300

Bug 1812910: Needs to use is_array() before count() in PHP 7.2

Fixing up some more places, like elasticsearch results, where we are
trying to get a cound on a variable that is not an array

behatnotneeded

Change-Id: I09b809240f18892a187c5e5ed2a3d1756e39b247
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit ef57506f7aed492d6e988d2e62fa9e88e10f7ed6)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1812910

Title:
  count(): Parameter must be an array or an object that implements
  Countable in Importer

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  Importer needs to use is_array() instead of count() in PHP 7.2 when we
  are wanting to check if there is an array to loop over with foreach().

  Currently we try to loop over entries by checking with count() and we
  get error

  - count(): Parameter must be an array or an object that implements
  Countable

  when there is nothing set

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1812910/+subscriptions