mahara-contributors team mailing list archive

[Mahara Bot <1817809@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9616
Committed: https://git.mahara.org/mahara/mahara/commit/5a72857a4252624e81933a2509c2fe2bc9513c0f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 5a72857a4252624e81933a2509c2fe2bc9513c0f
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Thu Mar 7 14:45:49 2019 +1300

Bug 1817809: Add small logo to a theme

Added default mobile logo to theme.
It will change from light to dark version accordingly.

behatnotneeded

Change-Id: I0bfcdc93a159bad54cf974d3dc3993e22a2ba1eb
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1817809

Title:
  Add small logo to a theme

Status in Mahara:
  Fix Committed

Bug description:
  It is possible to upload a small logo via Admin menu -> Institutions
  -> Settings to each institution. However, the default themes in Mahara
  don't seem to provide the opportunity to have a small logo there per
  default, which makes it harder to theme because then no small logo
  could be uploaded via the theme.

  What should be possible?

  1. Add a small sitelogo (as SVG and PNG file) into the raw theme and
  other themes that contain a custom theme. That way, the logo would be
  picked up when the default themes are viewed. Logo files are provided
  below.

  We have several versions of the logo to account for dark backgrounds
  and light backgrounds in the configurable theme. Some of the other
  themes might also have their own version of the logo on the site to
  accommodate the background.

  2. When an institution uploaded a custom regular logo but no custom
  small logo, do not switch to the built-in small logo as that would
  change the brand. Keep the normal uploaded logo that gets a bit
  smaller.

  3. Rename "Small logo" in the institution settings to "Mobile logo" to
  make it more obvious that people should upload it. We can't force the
  upload of a logo though. A new language string ID needs to be created
  so that it's picked up by the translators.

  When an institution uploads a small logo that will be used instead.
  That already does work.

  To summarize for what should be possible in the end:
  A. No logo or mobile logo uploaded through the admin area: Use the theme's logo and mobile logo.

  B.Logo uploaded through the admin area: Use that logo instead of the
  theme's logo. Use it also on mobile devices and do not switch to the
  theme's mobile logo.

  C. Logo and mobile logo uploaded through the admin area: Use both
  instead of the theme's logo and mobile logo.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1817809/+subscriptions