mahara-contributors team mailing list archive

[Mahara Bot <1820927@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9640
Committed: https://git.mahara.org/mahara/mahara/commit/11534107429252db169e7445dd31f53e4d9c27a7
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 11534107429252db169e7445dd31f53e4d9c27a7
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Mar 20 12:22:09 2019 +1300

Bug 1820927: language string clash in view.php lang file

There are two $string['portfolio'] strings one needs to be uppercase

behatnotneeded

Change-Id: Ia5e0390e719099408105c34810dae2fed35ad9b5
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820927

Title:
  Two $string['portfolio'] language strings in view.php lang file

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  In Progress
Status in Mahara 18.04 series:
  In Progress
Status in Mahara 18.10 series:
  In Progress
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  There is

  $string['portfolio'] = 'portfolio';

  and

  $string['portfolio'] = 'Portfolio';

  but only the second one gets used

  We need to sort this out so uppercase one is

  $string['Portfolio'] = 'Portfolio';

  To test: 
  Before patch

  1) Create a group as an admin and turn on 'participation report'
  2) Go to the group 'report' page and see it mention '1 Portfolio' (should say '1 portfolio')
  3) Go to admin -> reports - the 'Pages by type' graph has 'Portfolio'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820927/+subscriptions