mahara-contributors team mailing list archive

[Mahara Bot <1821859@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9676
Committed: https://git.mahara.org/mahara/mahara/commit/f127f134cfd499daab6f9a6cf044487b703fdccb
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit f127f134cfd499daab6f9a6cf044487b703fdccb
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Thu Mar 28 16:00:04 2019 +1300

Bug 1821859: Remove "Add to friends" text on new page header button

updated the pieform to conditionally display the button label
added title to the forms button element

behatnotneeded

Change-Id: I8ccbb92b64680b0d33a33ea27671bd2a21855a77
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821859

Title:
  Remove "Add to friends" text on new page header button

Status in Mahara:
  Fix Committed

Bug description:
  Follow-on to bug #1815829:

  Problem only on Mahara master (soon to be 19.04):

  There is still the button label "Add to friends" on the profile page
  of a user when they allow friends to be auto-added. This shouldn't be
  the case. We should only see the icon and the text should be there as
  tool tip.

  To replicate:

  1. Set up two users.
  2. User 1 should have the account setting "Friends control" set to "New friends are automatically authorised".
  3. Log in as user 2 and go to the profile page of user 1.
  4. Actual result: You see the button "Add to friends" with icon and text (see attached screenshot).
     Expected result: You see the button only with the icon and the text is in a tool tip that you see when you hover over it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1821859/+subscriptions