mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #52603
[Bug 1821657] Re: Modern theme the success message and error message look too similar
Somehow, the success colour was set to be the theme primary color in
Raw, so Modern inherited it's blue primary color. Have now reset Raw
$success to a green.
Then realised that alerts (bootstrap) and states (mahara) are calculated
in different places, rewrite parts of states to inherit the same
variables as alerts so overriding only need to change a single variable
in bootstrap-variable.scss (eg $info, $warning, $success, $danger)
Stripped out state/alert variables from themes except Raw as don't
actually see the need to have them different. But the previous step is
still useful when there's specific need for inverse alerts/states.
Modern alert messages had a bigger padding given to it, removed it as
don't see how it's relevant.
** Changed in: mahara
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821657
Title:
Modern theme the success message and error message look too similar
Status in Mahara:
Fix Committed
Bug description:
Normally we have a green background to success messages
But on modern theme we have a greyish-rose background on success
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1821657/+subscriptions
References