mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #52656
[Bug 1821657] A change has been merged
Reviewed: https://reviews.mahara.org/9734
Committed: https://git.mahara.org/mahara/mahara/commit/901d1441c0c3dd2b8bcf1d317ed3911b91cecfbf
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch: master
commit 901d1441c0c3dd2b8bcf1d317ed3911b91cecfbf
Author: Evonne Cheung <evonne@xxxxxxxxxxxxxxx>
Date: Wed Apr 10 13:10:30 2019 +1200
Bug #1821657 Modern theme the success message and error message look too
similar
$success was set to be the $theme-primary-color in Raw, so Modern
inherited it's own $theme-primary-color which is blue/gray. Have
now reset Raw $success to a green.
Rewrote states to inherit the same variables as alerts so
overriding only need to change a single variable in
bootstrap-variable.scss (eg $info, $warning, $success, $danger)
Stripped out state/alert variables from themes except Raw as don't
actually see the need to have them different.
Modern alert messages had a bigger padding given to it, removed it
as don't see how it's relevant.
behatnotneeded
Change-Id: Iac9d8b52e5b085aaae2d4825296afac0651b0fee
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821657
Title:
Modern theme the success message and error message look too similar
Status in Mahara:
Fix Committed
Bug description:
Normally we have a green background to success messages
But on modern theme we have a greyish-rose background on success
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1821657/+subscriptions
References