mahara-contributors team mailing list archive

[Mahara Bot <1821995@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9750
Committed: https://git.mahara.org/mahara/mahara/commit/8b7940de72b18328b8797f9adef70fa021a87182
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit 8b7940de72b18328b8797f9adef70fa021a87182
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Apr 11 09:01:28 2019 +1200

Bug 1821995: Avoid duplicate 'view-wizard-controls' id on page edit

As valid HTML should have only unique ids for elements on a page

Change-Id: I21dce982cc9ad3a9dd2d754d4621f741f712484a
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 5880a0d21f754f3cc75e9601205a67ce9d1cfdc2)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821995

Title:
  edit page has duplicated "view-wizard-controls" in html tags

Status in Mahara:
  Fix Committed

Bug description:
  BUG SUMMARY: 
  When editing a page, if we inspect the html we can see there are two elements with the id="view-wizard-controls". All id's in html tags should be unique.
  We need to fix this either for the form that pop's up when adding a block to the page by clicking on the block menu, or fix it for the modal that contains it.
  ==============================================

  Environment tested: Master
  Browser tested: Chrome

  PRECONDITIONS: 
  1) Mahara user exists 
  2) developer tools are open to view the code

  TEST STEPS: 
  ------------------------ 
  1) Log in as Mahara user 
  2) Create a portfolio page and add a block (any will do) 
  3) Using the dev tools confirm there are no duplicate ID's

  Expected Result: No duplicate ID's are found on the page

  Actual Result: Found a duplicate ID on the page (id="view-wizard-
  controls")

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1821995/+subscriptions