mahara-contributors team mailing list archive

[Mahara Bot <1824441@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9759
Committed: https://git.mahara.org/mahara/mahara/commit/152c09207ea4191cd9b76d3fa9e8bef333f67475
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit 152c09207ea4191cd9b76d3fa9e8bef333f67475
Author: Evonne Cheung <evonne@xxxxxxxxxxxxxxx>
Date:   Fri Apr 12 11:46:42 2019 +1200

Bug #1824441 Custom layout thumbnail image appear circular in
Modern/Primary

Removed class from layout to not inherit .user-icon style, then
added styles to reframe the thumbnail properly.

behatnotneeded

Change-Id: If6a26457b79df783ed44fe1e4c7b57c2e9027d7e
(cherry picked from commit 119859d5bb6c72f8c927fffb27ddd2cee501499d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1824441

Title:
  Custom layout thumbnail image appear circular in Modern/Primary

Status in Mahara:
  Fix Committed

Bug description:
  In themes Modern and Primary school, the user-icon is circular. But
  the custom theme layout thumbnail has inherited that class, making it
  circular and hiding parts of the image when it should not.

  To relicate bug:
  1. Choose theme Modern or Primary school.
  2. Make a page.
  3. In settings page, scroll down to Layout tab and expand it.
  4. The affected image is the one right under the heading "Create custom layout".

  Expected result: clearly see the thumbnail.
  Actual result: corners of the thumbnail hidden as frame is rounded.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1824441/+subscriptions