← Back to team overview

mahara-contributors team mailing list archive

[Bug 1823864] A change has been merged

 

Reviewed:  https://reviews.mahara.org/9761
Committed: https://git.mahara.org/mahara/mahara/commit/1ae4cfca6565e878e70af0863213cc02a6cbd11f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit 1ae4cfca6565e878e70af0863213cc02a6cbd11f
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Wed Apr 10 16:44:34 2019 +1200

Bug 1823864: JSON editor- uploading matrix error string

behatnotneeded

Change-Id: I33163939fb71a5484b1d71f6ff00ba2d1506b0bb
(cherry picked from commit f8b2a68a66e4575a6ebd4ee2222b284a013923d9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1823864

Title:
  Incorrect error message on SmartEvidence upload page

Status in Mahara:
  Fix Committed

Bug description:
  Issue only in Mahara 19.04RC1 / master due to addition of
  SmartEvidence editor.

  When you attempt to upload a SmartEvidence file that does not have
  well-formatted JSON, the error message alludes to more info further
  down the page when there is no further information. That error message
  is taken from the "Editor" page but needs to be adapted for the
  "Upload" page.

  To replicate:

  1. Go to Admin menu -> Extensions -> SmartEvidence -> Upload.
  2. Upload a SmartEvidence .matrix file that has errors, e.g. create a file with a single word and save it as .matrix.

  Expected result: The error message says: "This is not a valid .matrix
  file: Unable to parse the JSON content."

  Actual result: The error message says: "The current form has invalid
  json. Please scroll down the page to see the specific error."

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1823864/+subscriptions


References