← Back to team overview

mahara-contributors team mailing list archive

[Bug 1824608] A change has been merged

 

Reviewed:  https://reviews.mahara.org/9810
Committed: https://git.mahara.org/mahara/mahara/commit/e977694bebcb1d5e3abf2d250c902c324c3af7ee
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit e977694bebcb1d5e3abf2d250c902c324c3af7ee
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Mon Apr 15 17:56:49 2019 +1200

Bug 1824608: Removed extra margin conditions from 'Default Theme' scss

- causing the 'Accept/Decline' button sit 13px higher than the correct position
- font size difference changed in another bug

behatnotneeded

Change-Id: I8cd2b1043750901dcde60b20ee5ff24d707a146c
(cherry picked from commit 0dff1c5b2a883df3e956b4d56f81789ec3921431)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1824608

Title:
  Correct placement of "Accept" and "Deny" buttons for group invitations

Status in Mahara:
  Fix Committed

Bug description:
  Issue after upgrading to Bootstrap 4.

  When you are invited to join a group, the "Accept" and "Deny" buttons
  are not correctly placed on Main menu -> Engage -> Groups (see
  attachment).

  To replicate:

  1. Create 2 users.
  2. Set up a group as user A.
  3. Invite user B.
  4. Log in as user B.
  5. Go to Main menu -> Engage -> Groups (/group/index.html).

  Expected result: You see the "Accept" and "Deny" buttons at the top of
  the box for the group for which the invitation is like shown in
  https://manual.mahara.org/en/18.10/_images/group_my_groups.png

  Actual result: The buttons are floating as per the screenshot.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1824608/+subscriptions


References