mahara-contributors team mailing list archive

[Mahara Bot <1697909@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9822
Committed: https://git.mahara.org/mahara/mahara/commit/3f05d3f4d7c5d76cd1b6b340fe3efc4572e8714e
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    18.10_STABLE

commit 3f05d3f4d7c5d76cd1b6b340fe3efc4572e8714e
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Apr 23 11:06:58 2019 +1200

Bug 1825894: Ignore extra parameters in webservices

We had a patch for ignoring parameters prefixed with 'custom_' in
bug 1697909 - but there were still problems from users when trying to
install LTI connections.

So we will now ignore any unknown parameter and let the user know by
recording this in the Mahara error log - we however will not be
returning the info about the extra parameters back to the system that
made the webservice call

behatnotneeded

Change-Id: I0cf5d966833a48e7db13d48b9e0be87285934002
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 515cfba646dee807fda37faeb89f8e71d132b379)
(cherry picked from commit e39ac7ce2f9824a67ac91e38fa76b80b4b392423)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1697909

Title:
  LTI (Canvas) gives exception: WebserviceInvalidParameterException

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released

Bug description:
  Having set up LTI in Mahara and provided Canvas with the Key/Secret
  and Launch URL:

  http://mahara-dev.stir.ac.uk/webservice/rest/server.php

  and custom parameter:

  wsfunction=module_lti_launch

  Clicking on the Mahara link gets:

  <EXCEPTION
  class="WebserviceInvalidParameterException"><ERRORCODE>invalidparameter</ERRORCODE><MESSAGE>Invalid
  parameter value detected; execution cannot continue.  : Unexpected
  keys
  (custom_canvas_course_uuid,custom_canvas_user_uuid,lis_course_offering_sourcedid,)
  detected in parameter array.</MESSAGE></EXCEPTION>

  similiar comes from Blackboard

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1697909/+subscriptions