← Back to team overview

mahara-contributors team mailing list archive

[Bug 1825600] A change has been merged

 

Reviewed:  https://reviews.mahara.org/9856
Committed: https://git.mahara.org/mahara/mahara/commit/28cd29e7f5e7906c387ed402d4dc439b3927d129
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit 28cd29e7f5e7906c387ed402d4dc439b3927d129
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Wed Apr 24 14:47:24 2019 +1200

Bug 1825600: Fix up colourization of delete buttons and messages

This affects:
- delete forum(interaction)
- delete topic
- delete forum post
- delete group

behatnotneeded

Change-Id: I73f445bb2e26605c5e81313d5ad10039dcfb4353
(cherry picked from commit 3f2e90e664acb44356d3539a4cf75caf3d22ca02)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1825600

Title:
  Forum post deletion shows incorrect button color and post background

Status in Mahara:
  Fix Committed

Bug description:
  When you delete a forum post in a group, there are two styling issues
  (see screenshot):

  1. The "Yes" button should only have the normal button color, i.e.
  grey, but not the primary button color.

  2. The post that is deleted is shown below the deletion message. It
  has a red background when it shouldn't have one to make the post
  easier to read.

  To replicate:

  1. Create a group and a forum topic.
  2. Make a forum post.
  3. Delete the forum post.

  Expected result: The "Yes" button has the standard grey button color,
  but not the class "btn-primary", and the forum post to be deleted is
  not shown with a red background.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1825600/+subscriptions


References