mahara-contributors team mailing list archive

[Mahara Bot <1826788@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9916
Committed: https://git.mahara.org/mahara/mahara/commit/9c7f25de2c2185bbeb94302a1f5c2225f81dd2df
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit 9c7f25de2c2185bbeb94302a1f5c2225f81dd2df
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Apr 29 12:55:16 2019 +1200

Bug 1826788: Allow tags on institutions / group items still show

When tags on an artefact / view / collection / blocktype not owned
by a user, but rather a group or institution we should still display
it for a user who belongs to that group / institution

behatnotneeded

Change-Id: I798f56826e1b285b54b8c430f6f7b89fac9b752e
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit a4a8e6ae5426c4d5eb100bc57ebd3d64096f4178)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826788

Title:
  Tags under institutions cause error

Status in Mahara:
  Fix Committed

Bug description:
  We now have a system where we can use special 'Institution tags' but
  we also allow institution admins to tag things in the normal was as
  well. The following case causes the error:

  [WAR] 9e (lib/form/elements/tags.php:100) Trying to get property of non-object
  Call stack (most recent first):

      log_message("Trying to get property of non-object", 8, true, true, "/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100) at /home/robertl/code/mahara-testing/mahara/htdocs/lib/errors.php:520
      error(8, "Trying to get property of non-object", "/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100, array(size 3)) at /home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/tags.php:100
      display_tag("fats", array(size 2)) at /home/robertl/code/mahara-testing/mahara/htdocs/artefact/file/lib.php:729
      ArtefactTypeFileBase::get_my_files_data(0null, null, "insttwo", null) at /home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/filebrowser.php:164

  
  Steps to reproduce:

  1) Have a site with an institution (Institution A) that contains 2 institution admins
  2) Institution admin A logs in and uploads a file to the Admin -> Institution -> Files section
  3) They then edit the file metadata and add a tag 'Cats'
  4) They log out
  5) Institution admin B logs in and goes to the Admin -> Institution -> Files section

  They see the error

  6) They then edit the file metadata and instead of seeing 'Cats' they
  see 'null'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826788/+subscriptions