mahara-contributors team mailing list archive

[Mahara Bot <1826937@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9919
Committed: https://git.mahara.org/mahara/mahara/commit/7f688075e93cd7550360b8d27f40ebfd078ce6dd
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit 7f688075e93cd7550360b8d27f40ebfd078ce6dd
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Apr 30 09:09:42 2019 +1200

Bug 1826937: Check correct id when deleting the comment from artefact

behatnotneeded

Change-Id: Ibe357e17ac9b37380cb4fc6c9c21615db9137ac6
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 751e070180d9a489e7b346adf60760215cb090ef)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826937

Title:
  Deleting comment in artefact view causes undefined property error

Status in Mahara:
  Fix Committed

Bug description:
  [WAR] 7e (artefact/comment/lib.php:1465) Trying to get property of non-object
  Call stack (most recent first):

      log_message("Trying to get property of non-object", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:520
      error(8, "Trying to get property of non-object", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465, array(size 13)) at /home/robertl/code/mahara-devel/mahara/htdocs/artefact/comment/lib.php:1465
      delete_comment_submit(object(Pieform), array(size 3)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:544

  This is because we are checking the view id rather than the artefact
  id the comment is attached to

  To replicate:

  1. Create 2 users.
  2. Log in as user A and create a page containing an image block
  3. Shared page with user B.
  4. Log in as user B and comment on the image block.
  5. Delete the comment.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826937/+subscriptions