← Back to team overview

mahara-contributors team mailing list archive

[Bug 1698699] A change has been merged

 

Reviewed:  https://reviews.mahara.org/9960
Committed: https://git.mahara.org/mahara/mahara/commit/d094f841794de2bf137a031fa44845c0a3441df2
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit d094f841794de2bf137a031fa44845c0a3441df2
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon May 6 14:00:40 2019 +1200

Bug 1698699: Rewrite path to PDF in HTML export

This patch rewrites the path to the html export version of the PDF file

behatnotneeded

Change-Id: I8d534af41258d219046e5f3586bf904777242cb9
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1698699

Title:
  Embedded PDFs not shown in HTML export

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed

Bug description:
  https://mahara.org/interaction/forum/topic.php?id=7904

  Embedded PDFs aren't show in the HTML report.

  
  Comment from Jono on this issue:

  https://bugs.launchpad.net/mahara/+bug/1279841/comments/1

  The iframe that holds the PDF still uses the mahara installation as
  the source URL, and iframes from external sources seem to be disabled
  in modern browsers if you've opened the HTML file locally (ie. you're
  using a file:// URL)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1698699/+subscriptions


References