mahara-contributors team mailing list archive

[Mahara Bot <1828303@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/9982
Committed: https://git.mahara.org/mahara/mahara/commit/77433f099e19b268cf53675dc7394f6f193bfafa
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 77433f099e19b268cf53675dc7394f6f193bfafa
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu May 9 09:06:55 2019 +1200

Bug 1828303: Make sure external auth object exists before calling logout

behatnotneeded

Change-Id: Ia984b9da76ecb8108cef7b20cfdd3a1b7d93108b
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1828303

Title:
  Unable to logout if session expires and authmethod gone away

Status in Mahara:
  Fix Committed

Bug description:
  If we login via an external auth method and while we are logged in the
  auth method becomes unavailable and then our session times out we
  can't logout as it tries to the call the external logout() on an empty
  object.

  We just get

  [WAR] 8d (lib/errors.php:535) [Error]: Call to a member function logout() on boolean
  Call stack (most recent first):

      exception(object(Error)) at Unknown:0

  We can get around it by closing the browser - but would be better to
  log user out correctly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1828303/+subscriptions