mahara-contributors team mailing list archive

[Mahara Bot <1827272@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10029
Committed: https://git.mahara.org/mahara/mahara/commit/33d1f34926a5233b3159d55978d2d0b0e9c41757
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 33d1f34926a5233b3159d55978d2d0b0e9c41757
Author: Rebecca Blundell <rebeccablundell@xxxxxxxxxxxxxxx>
Date:   Mon May 20 16:39:35 2019 +1200

Bug 1827272: move theme dropdown menu to page settings

-move select box from the page edit screen to
Settings-> Advanced
-remove no-longer-used code from views.js, blocks.tpl
and blocks.php
-update behat test
-add desc field for the theme chooser
I also fixed the 'Lock blocks' description, which had a grammatical error.

Change-Id: I4cddf3fe884d11cf950408041daf92d12915b2d3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827272

Title:
  Move the "Theme" drop-down menu to the page settings page

Status in Mahara:
  Fix Committed

Bug description:
  For 19.10 we are investigating the implementation of a combined block
  in which to do the choosing. See
  https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Basic_magic_block
  for more information.

  The "Theme" drop-down menu cannot be moved there and shouldn't really
  be on the layout page anyway. That drop-down menu should be moved to
  the "Settings" page of a page into the "Advanced" panel.

  To replicate:

  1. Ensure that users can select their own page themes by activating it in Admin menu -> Configure site -> Site options -> User settings -> "Users can choose page themes" to "Yes".
  2. Create a page and open the "Advanced" panel.
  Expected result: The "Theme" drop-down menu is displayed.
  3. Select your theme and save the page. You are taken to the "Edit" screen.
  Expected result: You should not see the "Theme" drop-down.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827272/+subscriptions