← Back to team overview

mahara-contributors team mailing list archive

[Bug 1832803] [NEW] Adding an empty string as a comment generates a warning

 

Public bug reported:

Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF


When entering a comment which does not have any text but includes an uploaded file, the following warning is generated:

[WAR] bd (artefact/comment/lib.php:1184) DOMDocument::loadHTML(): Empty string supplied as input
Call stack (most recent first):

    log_message("DOMDocument::loadHTML(): Empty string supplied as ...", 8, true, true, "/var/www/mahara/htdocs/artefact/commen...", 1184) at /var/www/mahara/htdocs/lib/errors.php:520
    error(2, "DOMDocument::loadHTML(): Empty string supplied as ...", "/var/www/mahara/htdocs/artefact/commen...", 1184, array(size 2)) at Unknown:0
    DOMDocument->loadHTML("", 8196) at /var/www/mahara/htdocs/artefact/comment/lib.php:1184
    ArtefactTypeComment::remove_comments_classes("") at /var/www/mahara/htdocs/artefact/comment/lib.php:1637
    add_feedback_form_submit(object(Pieform), array(size 8)) at /var/www/mahara/htdocs/lib/pieforms/pieform.php:544
    Pieform->__construct(array(size 9)) at /var/www/mahara/htdocs/lib/pieforms/pieform.php:166
    Pieform::process(array(size 9)) at /var/www/mahara/htdocs/lib/mahara.php:5400
    pieform(array(size 9)) at /var/www/mahara/htdocs/view/view.php:266


To reproduce:
* Create a view with a comment section
* View the page and enter a comment
* Upload a file for the comment and leave the content empty.
* Save
* Refresh page
* The above warning appears

Expected: no warning should appear.

** Affects: mahara
     Importance: Undecided
     Assignee: Ghada El-Zoghbi (ghada-z)
         Status: New

** Changed in: mahara
     Assignee: (unassigned) => Ghada El-Zoghbi (ghada-z)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1832803

Title:
  Adding an empty string as a comment generates a warning

Status in Mahara:
  New

Bug description:
  Mahara: 19.04.0
  OS: Linux 16.04
  DB: Postgres
  Browser: FF

  
  When entering a comment which does not have any text but includes an uploaded file, the following warning is generated:

  [WAR] bd (artefact/comment/lib.php:1184) DOMDocument::loadHTML(): Empty string supplied as input
  Call stack (most recent first):

      log_message("DOMDocument::loadHTML(): Empty string supplied as ...", 8, true, true, "/var/www/mahara/htdocs/artefact/commen...", 1184) at /var/www/mahara/htdocs/lib/errors.php:520
      error(2, "DOMDocument::loadHTML(): Empty string supplied as ...", "/var/www/mahara/htdocs/artefact/commen...", 1184, array(size 2)) at Unknown:0
      DOMDocument->loadHTML("", 8196) at /var/www/mahara/htdocs/artefact/comment/lib.php:1184
      ArtefactTypeComment::remove_comments_classes("") at /var/www/mahara/htdocs/artefact/comment/lib.php:1637
      add_feedback_form_submit(object(Pieform), array(size 8)) at /var/www/mahara/htdocs/lib/pieforms/pieform.php:544
      Pieform->__construct(array(size 9)) at /var/www/mahara/htdocs/lib/pieforms/pieform.php:166
      Pieform::process(array(size 9)) at /var/www/mahara/htdocs/lib/mahara.php:5400
      pieform(array(size 9)) at /var/www/mahara/htdocs/view/view.php:266

  
  To reproduce:
  * Create a view with a comment section
  * View the page and enter a comment
  * Upload a file for the comment and leave the content empty.
  * Save
  * Refresh page
  * The above warning appears

  Expected: no warning should appear.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1832803/+subscriptions


Follow ups