← Back to team overview

mahara-contributors team mailing list archive

[Bug 1831419] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10088
Committed: https://git.mahara.org/mahara/mahara/commit/60bbf50e8eebea2db532584575ec95626b23df98
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    18.04_STABLE

commit 60bbf50e8eebea2db532584575ec95626b23df98
Author: Ghada El-Zoghbi <ghada@xxxxxxxxxxxxxxx>
Date:   Mon Jun 3 19:43:58 2019 +1000

Bug 1831419: validate insertion of event log for comment

When a page is shared by a group and the event log
is set to All, check if a log needs to be inserted
for the event: sharedcommenttogroup.

Sponsored by The Australian National University

behatnotneeded

Change-Id: Iafe2120a37049a1b1bca9ab1e23503d93efc12ea
(cherry picked from commit 7040639d50ac68759656d50feb79f0edd4b40f68)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1831419

Title:
  Notification when Importing Leap2A

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed

Bug description:
  Mahara: 19.04.04
  DB: Postgres
  OS: Linux
  Browser: FF

  When importing a view with a comment block, the following warning is
  generated:

  
  [WAR] ed (lib/mahara.php:2056) Undefined index: onview
  Call stack (most recent first):

  
      log_message("Undefined index: onview", 8, true, true, "/var/www/mahara/htdocs/lib/mahara.php", 2056) at /var/www/mahara/htdocs/lib/errors.php:520
      error(8, "Undefined index: onview", "/var/www/mahara/htdocs/lib/mahara.php", 2056, array(size 23)) at /var/www/mahara/htdocs/lib/mahara.php:2056
      handle_event("blockinstancecommit", object(BlockInstance)) at /var/www/mahara/htdocs/blocktype/lib.php:1480
      BlockInstance->commit() at /var/www/mahara/htdocs/lib/view.php:2463
      View->addblockinstance(object(BlockInstance)) at /var/www/mahara/htdocs/lib/view.php:3400
      View::import_from_config(array(size 12), "2", "leap") at /var/www/mahara/htdocs/import/leap/lib.php:1036
      PluginImportLeap->import_view_from_request(object(stdClass)) at /var/www/mahara/htdocs/import/leap/lib.php:1005
      PluginImportLeap->import_from_requests() at /var/www/mahara/htdocs/import/leap/lib.php:348
      PluginImportLeap->do_import_from_requests() at /var/www/mahara/htdocs/import/index.php:314
      do_import() at /var/www/mahara/htdocs/import/index.php:71

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1831419/+subscriptions


References