mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #54455
[Bug 1785985] A change has been merged
Reviewed: https://reviews.mahara.org/10024
Committed: https://git.mahara.org/mahara/mahara/commit/4c620d4d4a93771ddf4932c1a8b34d9aa26fcdad
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch: 19.04_STABLE
commit 4c620d4d4a93771ddf4932c1a8b34d9aa26fcdad
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date: Thu May 16 09:47:25 2019 +1200
Bug 1785985: Offset the problematic cron jobs
As mentioned in forum post
https://mahara.org/interaction/forum/topic.php?id=8450#post33705
behatnotneeded
Change-Id: I700c295d6d4ced232a119c3f8dbbc922a73298d3
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1785985
Title:
Remove triggers from Mahara database
Status in Mahara:
In Progress
Bug description:
I've created a forum post to discuss this:
* https://mahara.org/interaction/forum/topic.php?id=8324
Basically, my reasoning is:
1. Mahara supports two DB types - MySql and Postgres. Each DB has different syntax when it comes to creating/updating/deleting triggers. This makes it complicated to develop and maintain.
2. Mahara already has the concept of events in place. We can move the
functionality of each trigger into an event. We would then have more
control over the event. For example, don't action an event during an
upgrade.
3. Triggers make it difficult to see what is actually happening. They
are not transparent. If you weren't aware that there is a trigger on
the table, it can make it difficult to track down why something is
behaving in a certain way.
We can start slowly by removing one at a time. It doesn't have to happen all at once.
Just my thoughts.
Cheers.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1785985/+subscriptions
References