mahara-contributors team mailing list archive

[Mahara Bot <1832308@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10120
Committed: https://git.mahara.org/mahara/mahara/commit/8f1eeb1235ce8fe1a21ba046295538a23097d445
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    19.04_STABLE

commit 8f1eeb1235ce8fe1a21ba046295538a23097d445
Author: Ghada El-Zoghbi <ghada@xxxxxxxxxxxxxxx>
Date:   Thu Jun 13 16:31:22 2019 +1000

Bug 1832308: Group setting and isolated institutions

The public setting on a group should not affect
the jointype.

Bring back original 18.10 functionality for
group settings page by:
* Removing the friends customisation.
* Removing affect of Public setting on other toggles.

Bring back original 18.10 functionality for who
can join a group:
* Users will be able to join the group on their own -
if it is open - regardless of the isolatedinstitutions
and public settings.

Please note for isolatedinstitutions:
Only site admins can create public groups.
It is up to the site admin to add users to groups
if they are set to public.
It is also up to the site admin to correctly set the jointype
for the group.
Therefore, for open groups, users can join the
group if it's in their institution.

Sponsored by The Australian National University

behatnotneeded

Change-Id: I0901f1ddf3b1c982dab0b3f4725755b6b0cdf5f2
(cherry picked from commit 53d7eb7a458d7613eac1edf2ffa328fa44c0113c)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1832308

Title:
  Cannot toggle Group's Open button

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed

Bug description:
  Mahara: 19.04.0
  OS: Linux 16.04
  DB: Postgres
  Browser: Firefox

  * Prerequiste: create an institution (Inst1) other than Mahara.

  * Created a group with the following settings:

  Group name = 1904 Upgrade Test G2
  Associate with Institution = Inst1
  Group homepage URL = 1904-upgrade-test-g2
  Open = No
  Controlled = Yes
  Request = Yes
  Roles: Course: Member, Tutor, Admin
  Friend Invitations: No
  Recommendations = No
  Create and edit = All group members
  Allow submissions = Yes
  Allow archiving of submissions = Yes
  Publicly viewable group = Yes
  Hide group = No
  Hide membership = Hide members
  Hide membership from members = No
  Participation report = Yes
  Auto-add users = No
  Shared page notifications = All group members
  Comment notifications = All group members
  Send forum posts immediately = Yes

  * Save the group settings.

  * Come back into the group settings page, the Open button is disabled
  - i.e. click on Controlled = No - should toggle the Open button on.

  Current Behaviour: Open button remains disabled
  Expected Behavious: Open button should be enabled.

  This will need to be tested with isolated institutions turned on and
  turned off. Isolation should not force the "open" option to be
  unavailable as only site admins can set up public groups when
  isolation is turned on and they can decide whether the group is to be
  open or not.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1832308/+subscriptions