← Back to team overview

mahara-contributors team mailing list archive

[Bug 1806524] Re: edit page has duplicated "addblock" in html tags

 

BUG SUMMARY:

Bug had to be reopened to fix the following issue:
1) The dialog box that appears cannot be closed by clicking the "x" at the top right anymore.
2) Dialog doesn't actually display the artefact titles in the drop down as it used to in previous Mahara versions.

==============================================

Commit hash: 3e87aac48617ddc6adfcaebdaa747f53579a4bbb
Environment tested: Master
Browser tested: Chrome
Theme used:  Raw | Default raw | Ocean | Modern | Primary school 

PRECONDITIONS: 
------------------------ 
1) Portfolio page with 3 column layout exists as follows 
   a) has a text block in top of first column
   b) has an image block under the text block in the first column
   c) has a comments block under the image block in the first column


TEST STEPS: 
------------------------ 
1) Log in as Site admin
2) Edit the portfolio page as mentioned above  
3) Click block type "Text"  (do not use drag and drop functionality)
4) Verify that a dialog box is displayed  ✔
5) Click the X icon in the top right of dialog box to close it 
6) Verify that that clicking the  X icon in the top right of dialog box to close it  ✔
7) Click block type "Text"  (do not use drag and drop functionality)
8) Verify the options in the dropdown field labeled Position are as follows  ✔
   a) Top of cell ✔
   b) After "Text" ✔
   c) After "Image"
   d) After "Comments" ✔
9) Make the selection of After "Image" and click the add button in the dialog box
10) Flyout modal should display - fill in required fields and click Save
11) Verify that the text block is inserted after the image block ✔


Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1806524

Title:
  edit page has duplicated "addblock" in html tags

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released

Bug description:
  when editing a page, if we inspect the html we can see there are two elements with the id="addblock". All id's in html tags should be unique.
  We need to fix this either for the form that pop's up when adding a block to the page by clicking on the block menu, or fix it for the modal that contains it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1806524/+subscriptions


References