mahara-contributors team mailing list archive

[Ghada El-Zoghbi <ghada@xxxxxxxxxxxxxxx>]

** Description changed:

  Mahara: 19.04
  OS: Linux 16.04
  DB: Postgres 10.9
  Browser: FF
  
  Inserting a navigation block at the end of the middle column does not
  add the block in the same position on the other pages in the collection.
  
  Scenario:
  * Create 3 pages (Pg1, Pg2, Pg3)
  
  * Create 3 text blocks on each page across the page:
  - Pg 1:  Text 1 in row 1, col1
  - Pg 1:  Text 2 in row 1, col2
  - Pg 1:  Text 3 in row 1, col3
  - Pg 2:  Text 1 in row 1, col1
  - Pg 2:  Text 2 in row 1, col2
  - Pg 2:  Text 3 in row 1, col3
  - Pg 3:  Text 1 in row 1, col1
  - Pg 3:  Text 2 in row 1, col2
  - Pg 3:  Text 3 in row 1, col3
  
  * Edit Pg2 and add a navigation block in row2, col2
  - Block title: Nav Block from Pg 2
  - Add to all pages = Yes
  - Save
  
  * Display the collection
  - Navigation block on Pg1 is in row1, col2 => incorrect: shuffled up because there was already a block in that cell.
  - Navigation block on Pg2 is in row2, col2 => correct
  - Navigation block on Pg3 is in row1, col2 => incorrect: shuffled up because there was already a block in that cell.
  
- 
  Expected results:
  - Navigation block on Pg1 is in row2, col2
  - Navigation block on Pg2 is in row2, col2
  - Navigation block on Pg3 is in row2, col2
- 
  
  I don't actually have a solution for this. The shuffle_helper() function
  in (htdocs/lib/view.php) is doing the correct behaviour by shifting the
  existing blocks down by 1 to allow space for the newly inserted block.
  
  * Do we want to have a "force position" perhaps?
- * Or, do we want to set the 'order' of the newly added navigation block to something huge like 9999 to make sure it come in last?
+ * Or, do we want to set the 'order' of the newly added navigation block to something huge like 9999 to make sure it come in last? 
  
- But, I'm not sure what the implications of each will be on other blocks.
- Any thoughts?
+ The second option is not "correct" either when it's added as the first
+ item in the column...
+ 
+ If we set the order to 9999 (i.e. make it the last block order) then, it
+ will add the block on the other pages in row 2 / col2.
+ 
+ 
+ But, I'm not sure what the implications of each will be on other blocks. Any thoughts?

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1836657

Title:
  Navigation block position is not inserted in selected row

Status in Mahara:
  New

Bug description:
  Mahara: 19.04
  OS: Linux 16.04
  DB: Postgres 10.9
  Browser: FF

  Inserting a navigation block at the end of the middle column does not
  add the block in the same position on the other pages in the
  collection.

  Scenario:
  * Create 3 pages (Pg1, Pg2, Pg3)

  * Create 3 text blocks on each page across the page:
  - Pg 1:  Text 1 in row 1, col1
  - Pg 1:  Text 2 in row 1, col2
  - Pg 1:  Text 3 in row 1, col3
  - Pg 2:  Text 1 in row 1, col1
  - Pg 2:  Text 2 in row 1, col2
  - Pg 2:  Text 3 in row 1, col3
  - Pg 3:  Text 1 in row 1, col1
  - Pg 3:  Text 2 in row 1, col2
  - Pg 3:  Text 3 in row 1, col3

  * Edit Pg2 and add a navigation block in row2, col2
  - Block title: Nav Block from Pg 2
  - Add to all pages = Yes
  - Save

  * Display the collection
  - Navigation block on Pg1 is in row1, col2 => incorrect: shuffled up because there was already a block in that cell.
  - Navigation block on Pg2 is in row2, col2 => correct
  - Navigation block on Pg3 is in row1, col2 => incorrect: shuffled up because there was already a block in that cell.

  Expected results:
  - Navigation block on Pg1 is in row2, col2
  - Navigation block on Pg2 is in row2, col2
  - Navigation block on Pg3 is in row2, col2

  I don't actually have a solution for this. The shuffle_helper()
  function in (htdocs/lib/view.php) is doing the correct behaviour by
  shifting the existing blocks down by 1 to allow space for the newly
  inserted block.

  * Do we want to have a "force position" perhaps?
  * Or, do we want to set the 'order' of the newly added navigation block to something huge like 9999 to make sure it come in last? 

  The second option is not "correct" either when it's added as the first
  item in the column...

  If we set the order to 9999 (i.e. make it the last block order) then,
  it will add the block on the other pages in row 2 / col2.

  
  But, I'm not sure what the implications of each will be on other blocks. Any thoughts?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1836657/+subscriptions