← Back to team overview

mahara-contributors team mailing list archive

[Bug 1837660] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10234
Committed: https://git.mahara.org/mahara/mahara/commit/0f5a0f71d88c8a29b9468c94dccb8de075c12907
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    18.10_STABLE

commit 0f5a0f71d88c8a29b9468c94dccb8de075c12907
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Jul 24 08:08:10 2019 +1200

Bug 1837660: Need to return id to do subsequent query

So that the correct user is fetched

behatnotneeded

Change-Id: I59bb680f7b450bf2fb40256a44fae4a2413590f2
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 99cab79133929bb202a78780eab9420e73fe3c21)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1837660

Title:
  Error in Ldap user sync

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed

Bug description:
  When there is an existing matching email on the
  artefact_internal_profile_email but not on the usr.email field there
  is an error thrown on line 1334 of auth/ldap/lib.php

   EXECUTE("SELECT * FROM "usr" WHERE "id" = ? LIMIT 2")Command was:
  SELECT * FROM "usr" WHERE "id" = ?

  See
  https://mahara.org/interaction/forum/topic.php?id=8483&offset=0&limit=10#post33840

  This is because we only check for email and return boolean and then
  try to fetch info based on an object.

  Will fix

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1837660/+subscriptions


References