mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #55010
[Bug 1775479] A change has been merged
Reviewed: https://reviews.mahara.org/9602
Committed: https://git.mahara.org/mahara/mahara/commit/3611725eb8a7a897bb228a4dd6ba0f0cd39ad4c1
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch: master
commit 3611725eb8a7a897bb228a4dd6ba0f0cd39ad4c1
Author: Rebecca Blundell <rebeccablundell@xxxxxxxxxxxxxxx>
Date: Wed Feb 27 12:15:55 2019 +1300
Bug 1775479: remove obsolete comment code
remove some un-needed code
can't find anything else that should go
behatnotneeded
Change-Id: I25f978739640a895bd54ea1d9781bc537db4b029
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1775479
Title:
obsolete code for displaying comments
Status in Mahara:
Fix Committed
Bug description:
We have old code not used anymore for displaying comment list from a text note
in view/view.php ln 308
It was added in commit e03327b0f68d6c7bc40cd04cfed441f42b802ba3 in
15.04
for
"Adjusting the textbox so it can show/hide comments (Bug #1037531)
The comments will be displayed (or hidden) below the block by clicking
on the 'Comments (x)' link. There is also a 'close' link at the bottom
of the comment list as well to close them."
We don't use this anymore since now, when clicking on coment(x) link,
they are displayed in a right side modal panel.
We have to check what other obsolete related code we need to clean.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1775479/+subscriptions
References