← Back to team overview

mahara-contributors team mailing list archive

[Bug 1838915] Re: Comment ratings not displaying correctly with font-awesome5

 

Commit hash: 4c438c15998d1f0caa37b60f90b33604541a6790
Environment tested: Master
Browser tested: Chrome
Theme used:  Raw | Default raw | Ocean | Modern | Primary school 

PRECONDITIONS: 
------------------------ 
1) Comment ratings are enabled (Go to Admin -> Extensions -> Plugin administration and click on the cog for 'Comments')

TEST STEPS: Test comments on page:
------------------------ 
1) Go to a page and add a comment and choose a rating by clicking on the icon
2) Make sure the comment has the rating icons showing ✔


Test comments on artefact:
1) Go to a page and add an artefact, like an image, then view the page and click on details link
2) Make a comment on the artefact and choose a rating by clicking on the icon
3) Make sure the comment has the rating icons showing ✔

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1838915

Title:
  Comment ratings not displaying correctly with font-awesome5

Status in Mahara:
  In Progress

Bug description:
  The hollow (not rated) icons are not showing

  This will need to be tested for all the icon choices - star, heart,
  thumbsup, tick, smile (a new one)

  To test admin part:

  1) Go to Admin -> Extensions -> Plugin administration and click on the cog for 'Comments'
  2) Turn on 'Enable comment ratings'
  3) Select a new icon type
  4) Save

  On this page you should see some icons filled in and some hollow in
  the generated example line

  To test comments part on page:
  1) Go to a page and add a comment and choose a rating by clicking on the icon
  2) Make sure the comment has the rating icons showing

  To test comments part on artefact:
  1) Go to a page and add an artefact, like an image, then view the page and click on details link
  2) Make a comment on the artefact and choose a rating by clicking on the icon
  3) Make sure the comment has the rating icons showing

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1838915/+subscriptions


References