mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

** Changed in: mahara/18.10
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1839499

Title:
  Site pages and collections : Site unavailable error after enabling lti
  plugin.

Status in Mahara:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed

Bug description:
  Hi,

  I use Mahara 18.10.1 on ubunto 16.04.3, php 7.0.8, apache2 and
  Postgres 10.6.


  After enabling LTI plugin , and logging as a non-admin user , if we
  visit pages and collections page, it will through site unavailable
  error.

  Steps to reproduce
  * Visit the site.
  * Make sure we have enabled the LTI Plugin.
  * Login as a non-admin user.
  * Go to the Pages and collections page(Main menu->Create->Pages and Collections)
  * Site unavailable Error

  More precisely,On switching on the debug mode We are getting this
  error because of an Sql Exception after swtiching on the lTI plugin.It
  says group by is required while selecting a.id (lti as a )when using
  aggregate function.

  Here goes the git diff output:

  diff --git a/htdocs/lib/view.php b/htdocs/lib/view.php
  --- a/htdocs/lib/view.php
  +++ b/htdocs/lib/view.php
  @@ -4168,8 +4168,9 @@ class View {
               $collfrom .= $fromstr;
   
               if (!empty($groupby)) {
  -                $groupby .= ', g.id, h.wwwroot';
  -                $collgroupby .= ', g.id, h.wwwroot';
  +                // CATALYST CUSTOM - adding groupby condition for lti_assessment id column.
  +                $groupby .= ', g.id, h.wwwroot' . ($haslti ? ', a.id' : '');
  +                $collgroupby .= ', g.id, h.wwwroot' . ($haslti ? ', a.id' : '');
               }
               $sort = '
                   ORDER BY ' . $order . ' vtitle, vid';

  To correct this problem we need to add the LTI (a.id) in the group by
  condition(with a condition if LTI is enabled)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1839499/+subscriptions