mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #55082
[Bug 1838915] A change has been merged
Reviewed: https://reviews.mahara.org/10242
Committed: https://git.mahara.org/mahara/mahara/commit/0b568cedc8399957d0e2bec67d3926c093a5a855
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch: master
commit 0b568cedc8399957d0e2bec67d3926c093a5a855
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date: Mon Aug 5 13:31:25 2019 +1200
Bug 1838915: Fixing problem with comment ratings and fontawesome 5
Places to check
- the Extensions -> Plugins -> Comment configuration
- adding a Comment to a page/artefact and how it displays
Change-Id: I6d0945ee0d54492b65ff285d98bd65bc14d6e723
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1838915
Title:
Comment ratings not displaying correctly with font-awesome5
Status in Mahara:
Fix Committed
Bug description:
The hollow (not rated) icons are not showing
This will need to be tested for all the icon choices - star, heart,
thumbsup, tick, smile (a new one)
To test admin part:
1) Go to Admin -> Extensions -> Plugin administration and click on the cog for 'Comments'
2) Turn on 'Enable comment ratings'
3) Select a new icon type
4) Save
On this page you should see some icons filled in and some hollow in
the generated example line
To test comments part on page:
1) Go to a page and add a comment and choose a rating by clicking on the icon
2) Make sure the comment has the rating icons showing
To test comments part on artefact:
1) Go to a page and add an artefact, like an image, then view the page and click on details link
2) Make a comment on the artefact and choose a rating by clicking on the icon
3) Make sure the comment has the rating icons showing
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1838915/+subscriptions
References