← Back to team overview

mahara-contributors team mailing list archive

[Bug 1745250] Re: composer.json settings allow dev versions for php

 

** Changed in: mahara
   Importance: Undecided => Wishlist

** Changed in: mahara
       Status: New => Confirmed

** Changed in: mahara
   Importance: Wishlist => High

** Changed in: mahara
    Milestone: None => 19.10.0

** Summary changed:

- composer.json settings allow dev versions for php
+ composer.json settings allow dev versions for php: Specify max version

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1745250

Title:
  composer.json settings allow dev versions for php: Specify max version

Status in Mahara:
  Confirmed

Bug description:
  Looking at composer.json to see if we should update dependencies to make tests run better, I see that our syntax for php >=5.3.3 allows any version above that specified with default stability as dev. It explains how I ended up with php 7.2 after running make initcomposer...
  I think our default stability should be stable and that we should think about specifying a maximum version.

  Should we also change our settings to allow some other upgrades if
  there is a new stable non-breaking release, or just leave things
  pinned? If we change to "^version", it allows upgrades up to but not
  including the next major version, which seems reasonable??

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1745250/+subscriptions


References