mahara-contributors team mailing list archive

[Rangi Daymond <1827811@xxxxxxxxxxxxxxxxxx>]

Patchset: https://reviews.mahara.org/#/c/10304/6
Browser tested: Firefox
Theme used: Raw 

*PRECONDITIONS:
----------------
1) Logged in (non administrative) user1 has a newly created portfolio with:
   a) at least two Journals with several Journal entries in each with a couple of shared tags across them and at least one entry with a long title 
   b) a page that contains the following (populated) blocks:
      1.1 Embedded media 
      1.2 Image 	         
      1.3 Image gallery 
      1.4 PDF 		
      1.5 Some HTML
      1.6 Note	
      1.7 Journal
      1.8 Recent journal entries
      1.9 Tagged journal entries --> ensure to select the option 'Show journal entries in full' ie set to Yes
  	
2) The portfolio/page is shared with at least one other non administrative user (user2)	 

*TEST STEPS:
-------------
Step 1) As logged in user1, display the target portfolio/page then select the page 'Details' button (above the 'Edit' button, near top on right)
Step 2) Check the styling, positioning and functionality of the various block comment & detail bars/icons

***ISSUE1: 
----------
Expected results: The styling and positioning of the various block comment & detail bars/icons are as follows:
   1.1 Embedded media (bar - details only, positioned at top of block) X
   1.2 Image (bar - details and comments, positioned at top of block)  ✓         
   1.3 Image gallery (bar - details only, positioned at top of block)  X
   1.4 PDF (bar - details and comments, positioned at top of block)    X	
   1.5 Some HTML (bar - details only, positioned at top of block)      X
   1.6 Note (bar - details and comments, positioned at top of block)   ✓			
   1.7 Journal with 1+ Journal entries --> one per entry (icons - details and comments, positioned on top right of entry title) ✓
   1.8 Recent journal entries --> one each entry (icons - details and comments, positioned on top right of entry title) ✓
   1.9 Tagged journal entries --> one each entry (icons - details and comments, positioned on top right of entry title) X
        --> the entry item styling should be as per the Recent journal entry styling X
   2.0 Long titles of blocks that use comment and/or detail icons should be readable X

Actual results: please see attached annotated screenshots (filenames prefixed with SS1 & SS2-1, SS2-2 & SS2-3), as expected above except for:
   1.1 Embedded media, 1.3 Image Gallery & 1.5 Some HTML: the bar position is incorrect (under instead of above the title when present), see SS1
   1.4 PDF should be a bar (not icons) positioned at the top of the block, see SS1
   1.9 Tagged journal entries should each have comment (if user selected) and/or detail icons to the right of their (wrapped if necessary) title, see SS2-1, SS2-2 & SS2-3.  The entry item styling is not as per the Recent journal entry styling, see SS2-1
   2.0 Jounal entries with long titles are partially covered by the comment and/or detail icon/s, see SS2-1.

***ISSUE2:
----------
Step 3) Scroll to view the PDF block and click on the comment icon and add a Comment
Expected results: the comment icon should update to include an incremented comment count value eg from none to 1, 1 to 2 etc. and when the user refreshes the page (eg F5) and reselects the 'Details' button, the PDF count value should be retained.

Actual result: the Comment count is not displayed (unless the user adds
another or deletes one or more), see SS3

***ISSUE3:
----------
Step 4) Edit the page and add a new block (eg an image block) - do NOT add a file (or edit an existing block and remove the file name)
step 5) Display the page and select the 'Details' button
Step 6) Select to add a comment to the image block

Expected result: the image comments and detail modal will be displayed and the user can add a comment if they wish
Actual result: the modal is opened but is frozen in Loading state, see SS4

***ISSUE4:
----------
Step 7) Display the page, select the Details button and choose to add one or more comments to a block (used an Image block but happens for other types too)
step 5) Display the page and select to edit the block with one or more comments
Step 6) Delete/remove all the comment/s 

Expected result: the comments and details bar will be updated to indicate that there are no comments
Actual result: a different icon is displayed instead, see SS5-1, SS5-2 & SS5-3


** Attachment added: "SS1 Block Comments and details area positioning inconsistent.png"
   https://bugs.launchpad.net/mahara/+bug/1827811/+attachment/5288183/+files/SS1%20Block%20Comments%20and%20details%20area%20positioning%20inconsistent.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827811

Title:
  Move "Add comment" and "Details" into modal with "Comments"

Status in Mahara:
  In Progress

Bug description:
  This is part of the page revamp:
  https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Page_layout_revision

  Currently, the "Add comment" and "Details" links at blocks that can
  have them, takes you to a separate page where you can view the
  artefact's metadata and can leave comments.

  When you view comments, they are already displayed in the modal
  directly on the page, but you can't leave a comment yet.

  The things to be done:

  - Combine comments, add comment, Details to "Comments and details" (or just comments or just details depending on what can be displayed) so you only have one link.
  - Clicking that link opens up a modal on the page that shows the artefacts details (if there are any) and also the comments, as well as allows you to leave comments if that is enabled. Please see the attached mock-up.

  This would also mean to review all the "Details" on blocks as some of
  them are not needed. For example, clicking the details link next to a
  plan task only shows that single plan task again without any
  additional details. The "Details" should only be there when there is
  additional metadata information but not simply repeating the block
  content.

  The title of the modal (the one in the green bar) would be the
  blocktype as the title of the block is listed below.

  A decision still needs to be made on whether comments can be paginated
  in the modal or if they are shown all one after another (which might
  get quite long).

  We are not changing anything else from the proposal as that requires
  Gridstack to be implemented first. This is a standalone usability
  improvement independent of Gridstack.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827811/+subscriptions