← Back to team overview

mahara-contributors team mailing list archive

[Bug 1839032] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10243
Committed: https://git.mahara.org/mahara/mahara/commit/977986426db4093955a9a60307a37145a4227325
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 977986426db4093955a9a60307a37145a4227325
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Aug 6 09:14:47 2019 +1200

Bug 1839032: Adjust $user->find_by_instanceid_username()

Currently it checks either
- remote user table
or
- the user table

Allow it to check either
- remote user table
-- then user table if not found in remote user table
or
- the user table

Change-Id: Iaa5a59ea056a2a4ce40df324b0f084d0fcd941d8
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1839032

Title:
  Adjust find_by_instanceid_username() function to allow check remote
  then fallback to usr table

Status in Mahara:
  Fix Committed

Bug description:
  Currently the find_by_instanceid_username() function either only
  checks the remote user table (auth_remote_user) or it checks the user
  table (usr)

  It would be more useful if it could do the following:

  When $remoteuser flag is set:

  - Check remote user table and return user if a match found
  - But if no match found then fall back to check user table

  When $remoteuser flag is not set:

  - Just check user table

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1839032/+subscriptions


References