mahara-contributors team mailing list archive

[Rangi Daymond <1827811@xxxxxxxxxxxxxxxxxx>]

Gerrit/Patchset: https://reviews.mahara.org/#/c/10355/2
Browser tested: Firefox only at present
Theme used: Raw

*PRECONDITIONS:
----------------
1) Logged in (non administrative) user1 has a recently created portfolio/page with:
   a) at least two Journals with several Journal entries in each with a couple of shared tags across them and at least one entry with a long title
   b) a page that contains the following (populated) blocks:
      1.1 Embedded media
      1.2 Image
      1.3 Image gallery
      1.4 PDF
      1.5 Some HTML
      1.6 Note
      1.7 Journal
      1.8 Recent journal entries
      1.9 Tagged journal entries --> ensure to select the option 'Show journal entries in full' ie set to Yes
      1.10 Long block titles that use comment and/or detail icons should be readable
      1.11 File/s to download
      1.12 Folder

2) The portfolio/page is shared with at least one other non
administrative user (user2)

*TEST STEPS:
-------------
Step A) In each browser, log in as user1 then user2, display the target portfolio/page then select the page 'Details' button (above the 'Edit' button, near top on right)
Step B) Check the styling, positioning and functionality of the various block comment & detail bars/icons

Expected & Actual results: The styling and positioning of the various block comment & detail bars/icons are as follows:
   1.1 Embedded media (bar - details and comments, positioned at top of block) click bar for modal ✓
   1.2 Image (bar - details and comments, positioned at top of block) click bar or image for modal ✓
   1.3 Image gallery (bar - details only, positioned at top of block) click bar for modal or
                                  click an image for slideshow OR image modal - see issue 1 below  X
   1.4 PDF (bar - details and comments, positioned at top of block) click bar for modal  ✓
   1.5 Some HTML (bar - details only, positioned at top of block) click bar for modal    ✓
   1.6 Note (bar - details and comments, positioned at top of block) click bar for modal ✓
   1.7 Journal with 1+ Journal entries --> one per entry (icons - details and comments, positioned on top right of entry title) 
          click journal entry title or icon for modal - minor problem see Issue 2 below  X 
   1.8 Recent journal entries --> one each entry (icons - details and comments, positioned on top right of entry title) 
                                             click journal entry title or icon for modal ✓
   1.9 Tagged journal entries --> one each entry (icons - details and comments, positioned on top right of entry title)
                                             click journal entry title or icon for modal ✓
   1.10 Long titles of blocks that use comment and/or detail icons should be readable    ✓
   1.11 File/s to download --> one each entry (icons - details and comments, positioned on top right of entry title)
               click download to download or select the filename title or icon for modal ✓
   1.12 Folder --> sub-folder entry/ies (details icon only, positioned on top right of entry title)
          click folder name or details icon for modal displaying folder content - see issue 3 below X
               --> filename entry/ies ( 1 or both icons depending on file type, positioned on top right of entry title)
          mouse over (under the name) to download
             click filename or details icon for modal displaying folder content - see issue 4 below X

***ISSUE1: The Image gallery block is missing its Details only bar, clicking this should display the modal(see demo site Details
---------- link) that lists each file with some of its details and the file name that is linked to its Image details and comments
           modal as per 1.2 above.
           Also, as per the Mahara demo site, when the user selects an image from the gallery:
           - when the style is Slideshow, then the 4 arrows & their tooltips should show and the user should be able to scroll through
             the individual gallery contents within the block space
           - when the style is one of the other two thumbnail options then the user should be able to scroll through the
             individual gallery contents using the 4 supplied left/right arrows & full screen mode

***ISSUE2: The journal block has an extra line (than the Recent journal block) under the block title - see attachment prefixed with
---------- ISS2 note: this also happens in Chrome

***ISSUE 3 and 4: Folder/sub-folder blocks - once the Details/Details & comment modals are viewed for one of these entries, the page
----------------- must be reloaded (F5) before another entry's details and/or comments can be viewed via the modal.
           The Folder/sub-folder Details are not displayed correctly in the modal (see attachment prefixed ISS3)
           Note: these two behaviors are present in both Firefox and Chrome


** Attachment added: "ISS2 Journal block - extra line displayed under block title line.png"
   https://bugs.launchpad.net/mahara/+bug/1827811/+attachment/5289813/+files/ISS2%20Journal%20block%20-%20extra%20line%20displayed%20under%20block%20title%20line.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827811

Title:
  Move "Add comment" and "Details" into modal with "Comments"

Status in Mahara:
  In Progress

Bug description:
  This is part of the page revamp:
  https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Page_layout_revision

  Currently, the "Add comment" and "Details" links at blocks that can
  have them, takes you to a separate page where you can view the
  artefact's metadata and can leave comments.

  When you view comments, they are already displayed in the modal
  directly on the page, but you can't leave a comment yet.

  The things to be done:

  - Combine comments, add comment, Details to "Comments and details" (or just comments or just details depending on what can be displayed) so you only have one link.
  - Clicking that link opens up a modal on the page that shows the artefacts details (if there are any) and also the comments, as well as allows you to leave comments if that is enabled. Please see the attached mock-up.

  This would also mean to review all the "Details" on blocks as some of
  them are not needed. For example, clicking the details link next to a
  plan task only shows that single plan task again without any
  additional details. The "Details" should only be there when there is
  additional metadata information but not simply repeating the block
  content.

  The title of the modal (the one in the green bar) would be the
  blocktype as the title of the block is listed below.

  A decision still needs to be made on whether comments can be paginated
  in the modal or if they are shown all one after another (which might
  get quite long).

  We are not changing anything else from the proposal as that requires
  Gridstack to be implemented first. This is a standalone usability
  improvement independent of Gridstack.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827811/+subscriptions