← Back to team overview

mahara-contributors team mailing list archive

[Bug 1843691] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10339
Committed: https://git.mahara.org/mahara/mahara/commit/81733da12639cca1b76d79405a3837dd13e88f21
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit 81733da12639cca1b76d79405a3837dd13e88f21
Author: Kristina D.C. Hoeppner <kristina@xxxxxxxxxxxxxxx>
Date:   Thu Sep 12 21:36:53 2019 +1200

Bug 1843691: Correct spacing in submission report notification

Fixed the spacing in the notification to make it
more consistent with other mails.

Also fixed the subject where only "page" or "collection" was shown and
thus we don't need the quotation marks.

behatnotneeded

Change-Id: I5403c70dab8fed11718071573c1bc525ada4a768

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1843691

Title:
  Correct submission confirmation email lang string

Status in Mahara:
  Fix Committed

Bug description:
  New 19.10 functionality.

  There was an extra indentation in the email confirming that you've
  submitted a portfolio successfully to a group. I corrected the
  spacing.

  Before:

  ----------

  This is to confirm that you submitted the collection "Portfolio 4" successfully
  to the group "L&D" at 12-09-2019, 19:54.
                        If you have any questions about this submission, please
  contact the group administrator.
  ----------

  After:

  ----------
  This is to confirm that you submitted the collection "Portfolio 4" successfully
  to the group "L&D" at 12-09-2019, 19:54.

  If you have any questions about this submission, please contact the group administrator.
  -----------

  To replicate:

  Precondition: Set up a group that allows submissions and have Person A
  in there besides the group admin.

  1. Person A creates a page.
  2. Person A submits the page to the group.
  Expected result: Person A receives a notification in their Mahara inbox and via email if set up (default) that does not have a large indentation for the second sentence and where there is an empty line between the first and second sentence.

  Actual result: See "Before" scenario.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1843691/+subscriptions


References