mahara-contributors team mailing list archive

[Mahara Bot <1827811@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10157
Committed: https://git.mahara.org/mahara/mahara/commit/e6b6ecf9186d0f2bd9137da3ee5af105595126c9
Submitter: Cecilia Vela Gurovic (ceciliavg@xxxxxxxxxxxxxxx)
Branch:    master

commit e6b6ecf9186d0f2bd9137da3ee5af105595126c9
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Fri Jul 12 11:32:07 2019 +1200

Bug 1827811: Exports task

This change creates the modals for exported html pages.
Modals are hard-coded onto page with id's of modal_[artefactid]
Bootstrap and jquery files are copied into export js folder.
Profile page is also exported with any modal content.
Add tagged posts modals
get rid of export warning when no $commentcount set in viewposts.tpl
Add recent posts modals so that first journal post was also a modal
Set Parent journal link text to plain text for exports
Add entire resume modals and one resume field modals
Add File(s) to download modals
refactor export_artefact_metadata_modals
add metadata but not comments to resume page
add metata (license info) but not comments to journal pages
add comment count default to 0 in .tpl's if comment count not present (during export)
remove updating comments modals for profile page as this is no longer needed.

Change-Id: Iff50138285951a4f9a1573423f4f74feba97886f
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827811

Title:
  Move "Add comment" and "Details" into modal with "Comments"

Status in Mahara:
  In Progress

Bug description:
  This is part of the page revamp:
  https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Page_layout_revision

  Currently, the "Add comment" and "Details" links at blocks that can
  have them, takes you to a separate page where you can view the
  artefact's metadata and can leave comments.

  When you view comments, they are already displayed in the modal
  directly on the page, but you can't leave a comment yet.

  The things to be done:

  - Combine comments, add comment, Details to "Comments and details" (or just comments or just details depending on what can be displayed) so you only have one link.
  - Clicking that link opens up a modal on the page that shows the artefacts details (if there are any) and also the comments, as well as allows you to leave comments if that is enabled. Please see the attached mock-up.

  This would also mean to review all the "Details" on blocks as some of
  them are not needed. For example, clicking the details link next to a
  plan task only shows that single plan task again without any
  additional details. The "Details" should only be there when there is
  additional metadata information but not simply repeating the block
  content.

  The title of the modal (the one in the green bar) would be the
  blocktype as the title of the block is listed below.

  A decision still needs to be made on whether comments can be paginated
  in the modal or if they are shown all one after another (which might
  get quite long).

  We are not changing anything else from the proposal as that requires
  Gridstack to be implemented first. This is a standalone usability
  improvement independent of Gridstack.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827811/+subscriptions