mahara-contributors team mailing list archive

[Mahara Bot <1843149@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/10337
Committed: https://git.mahara.org/mahara/mahara/commit/9dc7cbc6a3a6ecdaf132888c6d755a5af20496b7
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 9dc7cbc6a3a6ecdaf132888c6d755a5af20496b7
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Thu Sep 12 12:08:59 2019 +1200

Bug 1843149: Bulk import doesn't retain user details correctly

This change does the following:
- Gets rid of the static cache that was created during run
of the first record which would only save the first user's info.
- when username is taken, append numbers and not underscores
- get rid of the warning using count on globals var that were not
previously set to array()s.
- respects the email users about their accounts option

behatnotneeded

Change-Id: I57b1c5e4d401028defda0c35bfc8347149094eb2
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1843149

Title:
  Bulk import doesn't retain user details correctly

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed

Bug description:
  This was reported at
  https://mahara.org/interaction/forum/topic.php?id=8502

  I can confirm it with a bulk export from account on demo.mahara.org
  (attached).

  For details, see the forum post.

  To replicate:

  Have 2 or more accounts that have files and portfolio pages, e.g. from
  demo.mahara.org

  1. Use the bulk export to export the accounts.
  2. On another Mahara site, use the bulk import to import the acocunts.
  Expected result: The accounts are transferred and set up as they were on the original site.

  Actual result: Everybody has the same name and profile pictures are
  not displayed even when the accounts had some. While email addresses
  were shown in the site admin area Admin menu -> People -> User search,
  no primary email address was shown on the accounts settings page and
  when logging in, an email validation was to be sent.

  Still to be tested on 18.10 and 18.04 if it's an issue there as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1843149/+subscriptions