← Back to team overview

mahara-contributors team mailing list archive

[Bug 1844470] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10375
Committed: https://git.mahara.org/mahara/mahara/commit/466b4a8a2c013d3c697af612029da4f591e5f3bd
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 466b4a8a2c013d3c697af612029da4f591e5f3bd
Author: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>
Date:   Tue Sep 24 16:04:42 2019 +1200

Bug 1844470: Move "Display page" and "Return to pages and collections"
to right-hand side on "Edit" screen

- create new edit page action buttons for return to <location> button
- delete references to the old display page link created in file editviewtabs.tpl
- delete file editviewtabs.tpl
- change the edit button in editviewpageactions.tpl into a display button
- change behat tests to reflect the change from Edit to Display page
- change the Behat instruction for And I display the page to target updated element
- delete the old display button styling from the style guide
- move url, title display logic into new func get_return_to_url_and_title in lib/view.php
- adjust blocks.php, access.php, editlayout.php to assign url, title using new func

behatnotneeded

Change-Id: Iedf2882c42fa1d204e438a23842834fbb9a709f9
Signed-off-by: Lisa Seeto <lisaseeto@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1844470

Title:
  Move "Display page" and "Return to pages and collections" to right-
  hand side on "Edit" screen

Status in Mahara:
  Fix Committed

Bug description:
  For Mahara 19.10 we moved all buttons on the edit screen of a page to
  the right-hand side. However, the "Display page" link at the top and
  "Display page" button and the "Return to pages and collections" /
  "Return to {group | institution | site} pages and collections" button
  are still in the same position making for an awkward navigation.

  It would be better if both "Display page" and "Return to pages and
  collections" were on the right-hand side below the "Share" button.
  That way we would also resolve needing to scroll up or down on long
  pages to get to them.

  Font Awesome icon for the "Display page" button: "tv"
  Font Awesome icon for "Return to pages and collections" button: step-backward

  Both icons need to be keyboard accessible and have tool tips "Display
  page" and "Return to pages and collections" respectively. "Return
  to..." would be:

  Return to pages and collections
  Return to group pages and collections
  Return to institution pages and collections
  Return to site pages and collections

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1844470/+subscriptions


References