← Back to team overview

mahara-contributors team mailing list archive

[Bug 1845061] A change has been merged

 

Reviewed:  https://reviews.mahara.org/10374
Committed: https://git.mahara.org/mahara/mahara/commit/7378486ada08b73d334d046d76a238f3f330228f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 7378486ada08b73d334d046d76a238f3f330228f
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Tue Sep 24 11:08:57 2019 +1200

Bug 1845061 Logo size in institution settings page

Restricting the size of the logo displayed within the form after
a image is uploaded, the logo has max height according to navbar
height variable, the logoxs has a set height of 48px, values based
on raw theme.

behatnotneeded

Change-Id: I92813a5c7c689675e55397cd26d870919d9bc33a

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1845061

Title:
  Restrict the size of the logo displays on institution settings page

Status in Mahara:
  Fix Committed

Bug description:
  When you upload a logo for an institution, it is displayed in its
  original size rather than the size that it will be displayed in on the
  page. This is problematic, esp. when very large images are uploaded
  because they break the page.

  We'll display a logo to the maximum dimensions of the logo on the
  site.

  This will go for both logo and mobile logo.

  To replicate:

  1. On the institution settings page, upload a large image as logo.
  Expected result: Logo is displayed in the same size as it will be used in the page header.
  Actual result: Logo is displayed in its original size.

  2. On the institution settings page, upload a large square logo as mobile logo.
  Expected result: Logo is displayed in the same size as it will be used in the page header.
  Actual result: Logo is displayed in its original size.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1845061/+subscriptions


References